-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T5794: firewall: change firewall priority in oder to be loaded after all interfaces #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-fort
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
fett0
August 15, 2024 17:48
👍 |
1 task
sever-sever
approved these changes
Aug 15, 2024
fett0
approved these changes
Aug 15, 2024
c-po
approved these changes
Aug 16, 2024
@Mergifyio backport sagitta circinus |
✅ Backports have been created
|
Won't this accept/allow all connections on startup until the firewall has been loaded, as the default action of the firewall without config is to accept all connections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Load firewall after all interfaces are created in the system.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
firewall
Proposed changes
How to test
Config shared in the example works and is correctly loaded into the system after reboot:
And nftables:
Smoketest result
test_firewall --> OK
Checklist: